docs: add KEP-0004 async upload registry abstraction#2534
Draft
jonburdo wants to merge 1 commit intokubeflow:mainfrom
Draft
docs: add KEP-0004 async upload registry abstraction#2534jonburdo wants to merge 1 commit intokubeflow:mainfrom
jonburdo wants to merge 1 commit intokubeflow:mainfrom
Conversation
Propose an abstract interface for model registry operations in the async-upload job, enabling support for multiple registry backends (e.g. MLflow) while keeping Kubeflow as the default. AI-assisted: Claude Code (Opus 4.6) Signed-off-by: Jon Burdo <jon@jonburdo.com>
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
jonburdo
commented
Apr 2, 2026
Comment on lines
+224
to
+236
| def get_registered_model_by_id(self, model_id: str) -> RegisteredModel: ... | ||
|
|
||
| def get_registered_model_by_name(self, name: str) -> RegisteredModel: ... | ||
|
|
||
| def get_model_version_by_params( | ||
| self, registered_model_id: str, name: str | ||
| ) -> ModelVersion: ... | ||
|
|
||
| def get_model_artifact_by_id(self, artifact_id: str) -> ModelArtifact: ... | ||
|
|
||
| def update_model_artifact(self, artifact: ModelArtifact) -> ModelArtifact: ... | ||
|
|
||
| def delete_registered_model(self, model_id: str) -> None: ... |
Member
Author
There was a problem hiding this comment.
I need to see if we can simplify a bit and avoid requiring all of these
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propose an abstract interface for model registry operations in the async-upload job, enabling support for multiple registry backends (e.g. MLflow) while keeping Kubeflow as the default.
AI-assisted: Claude Code (Opus 4.6)
Description
How Has This Been Tested?
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes